[ https://issues.apache.org/jira/browse/HADOOP-9065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13531674#comment-13531674 ]
Alejandro Abdelnur commented on HADOOP-9065: -------------------------------------------- But this will work only when padding of the counter is in effect, once you exceed the padding the typo issue could happen, right? you could do the typo killing for _1234 when trying to kill _12345, granted, the likelihood of _1234 still being around when _12345 is around is minimal. > JobID.forName() isn't strict enough > ----------------------------------- > > Key: HADOOP-9065 > URL: https://issues.apache.org/jira/browse/HADOOP-9065 > Project: Hadoop Common > Issue Type: Bug > Reporter: Robert Kanter > Assignee: Robert Kanter > Fix For: 1.2.0, 2.0.3-alpha > > Attachments: HADOOP-9065_branch-1.patch, HADOOP-9065.patch > > > If you have a job running as job_201208221603_0003, and then try to kill a > job passing id job_201208221603_003, it will kill job_201208221603_0003 > because the last part of the JobID is parsed as an integer. We should make > JobID.forName() stricter to prevent this and similar situations as the > current behavior isn't so obvious. > More specifically, we shouldn't accept JobIDs if the last part of the JobID > is: > {{-}} less than 4 characters (e.g. _003, _123) > {{-}} more than 4 characters and has a leading zero (e.g. _00003, _01234) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira