[ 
https://issues.apache.org/jira/browse/HADOOP-9140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13533541#comment-13533541
 ] 

Suresh Srinivas commented on HADOOP-9140:
-----------------------------------------

Comments:
# It might be good to call RpcEnginePb.proto to just RpcEngine.proto or 
ProtobufRpcEngine.proto. I prefer the first one.
# RpcHeader.proto - enum RpcRequestOperationProto could be moved into 
RpcRequestHeaderProto as just OpertionTypeProto.
# 
# RpcHeader.proto - enum RpcKindProto could also be moved into 
RpcRequestHeaderProto and can be renamed as RpcEngineKind.

                
> Cleanup rpc PB protos
> ---------------------
>
>                 Key: HADOOP-9140
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9140
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: Hadoop-9140-2.patch, Hadoop-9140.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to