[ https://issues.apache.org/jira/browse/HADOOP-9154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13545499#comment-13545499 ]
Surenkumar Nihalani commented on HADOOP-9154: --------------------------------------------- I debated initializing {{failureReason}} for a single assertion with myself when I was coding it and I went ahead it for three reasons: # Makes the code consistent. If you read the test from the start, you kinda start expecting it to have been initialized before every assert. # Easy extension. If anyone adds a bit more to the test, he/she wouldn't have to add initialization statement. # Code looks pretty and keeps all the assert statements (single assert ones especially) within 80 characters limit. If you think it's not worth above reasons, I am happy to change it and upload the patch. > SortedMapWritable#putAll() doesn't add key/value classes to the map > ------------------------------------------------------------------- > > Key: HADOOP-9154 > URL: https://issues.apache.org/jira/browse/HADOOP-9154 > Project: Hadoop Common > Issue Type: Bug > Components: io > Affects Versions: 2.0.2-alpha > Reporter: Karthik Kambatla > Assignee: Karthik Kambatla > Attachments: HADOOP-9124.patch, hadoop-9154-draft.patch, > hadoop-9154.patch, hadoop-9154.patch > > > In the following code from {{SortedMapWritable}}, #putAll() doesn't add > key/value classes to the class-id maps. > {code} > @Override > public Writable put(WritableComparable key, Writable value) { > addToMap(key.getClass()); > addToMap(value.getClass()); > return instance.put(key, value); > } > @Override > public void putAll(Map<? extends WritableComparable, ? extends Writable> t){ > for (Map.Entry<? extends WritableComparable, ? extends Writable> e: > t.entrySet()) { > > instance.put(e.getKey(), e.getValue()); > } > } > {code} -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira