[ 
https://issues.apache.org/jira/browse/HADOOP-9155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13549618#comment-13549618
 ] 

Hudson commented on HADOOP-9155:
--------------------------------

Integrated in Hadoop-Hdfs-trunk #1281 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1281/])
    HADOOP-9155. FsPermission should have different default value, 777 for 
directory and 666 for file. Contributed by Binglin Chang. (Revision 1431148)

     Result = FAILURE
atm : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1431148
Files : 
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileStatus.java
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/ftp/FTPFileSystem.java
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/local/RawLocalFs.java
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/permission/FsPermission.java
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileContextPermissionBase.java
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileStatus.java
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFSFileContextMainOperations.java
* 
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystemPermission.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSClient.java
* 
/hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocol/HdfsFileStatus.java

                
> FsPermission should have different default value, 777 for directory and 666 
> for file
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-9155
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9155
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.0.2-alpha
>            Reporter: Binglin Chang
>            Assignee: Binglin Chang
>            Priority: Minor
>             Fix For: 2.0.3-alpha
>
>         Attachments: HADOOP-9155.patch, HADOOP-9155.v2.patch, 
> HADOOP-9155.v3.patch, HADOOP-9155.v3.patch, HADOOP-9155.v3.patch
>
>
> The default permission for {{FileSystem#create}} is the same default as for 
> {{FileSystem#mkdirs}}, namely {{0777}}. It would make more sense for the 
> default to be {{0666}} for files and {{0777}} for directories.  The current 
> default leads to a lot of files being created with the executable bit that 
> really should not be.  One example is anything created with FsShell's 
> copyToLocal.
> For reference, {{fopen}} creates files with a mode of {{0666}} (minus 
> whatever bits are set in the umask; usually {{0022}}.  This seems to be the 
> standard behavior and we should follow it.  This is also a regression since 
> branch-1.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to