[ 
https://issues.apache.org/jira/browse/HADOOP-8924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-8924:
----------------------------------

    Attachment: HADOOP-8924-branch-trunk-win.3.patch
                HADOOP-8924.3.patch

I'm attaching version 3 of the patch for trunk and branch-trunk-win.  The 
differences since last time are that *.proto is included in the fileset for the 
MD5 calculation (see pom.xml files), and the MD5 calculation uses a 
platform-independent sort order for processing the files (see 
{{VersionInfoMojo#computeMD5}}).  The sort logic is a port of the earlier 
Python code on branch-trunk-win.

I've tested this on Mac, Windows, and Ubuntu.  MD5 calculations are consistent 
across platforms (though intentionally different from saveVersion.sh for the 
reasons discussed above).
                
> Hadoop Common creating package-info.java must not depend on sh, at least for 
> Windows
> ------------------------------------------------------------------------------------
>
>                 Key: HADOOP-8924
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8924
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Alejandro Abdelnur
>             Fix For: trunk-win
>
>         Attachments: HADOOP-8924.2.patch, HADOOP-8924.3.patch, 
> HADOOP-8924-branch-trunk-win.2.patch, HADOOP-8924-branch-trunk-win.3.patch, 
> HADOOP-8924-branch-trunk-win.patch, HADOOP-8924.patch
>
>
> Currently, the build process relies on saveVersion.sh to generate 
> package-info.java with a version annotation.  The sh binary may not be 
> available on all developers' machines (e.g. Windows without Cygwin). This 
> issue tracks removal of that dependency in Hadoop Common.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to