[ https://issues.apache.org/jira/browse/HADOOP-9124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13565421#comment-13565421 ]
Hadoop QA commented on HADOOP-9124: ----------------------------------- {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12566975/HADOOP-9124.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-common-project/hadoop-common. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2113//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2113//console This message is automatically generated. > SortedMapWritable violates contract of Map interface for equals() and > hashCode() > -------------------------------------------------------------------------------- > > Key: HADOOP-9124 > URL: https://issues.apache.org/jira/browse/HADOOP-9124 > Project: Hadoop Common > Issue Type: Bug > Components: io > Affects Versions: 2.0.2-alpha > Reporter: Patrick Hunt > Priority: Minor > Attachments: HADOOP-9124.patch, HADOOP-9124.patch, HADOOP-9124.patch, > HADOOP-9124.patch, HADOOP-9124.patch, HADOOP-9124.patch, HADOOP-9124.patch, > HADOOP-9124.patch, HADOOP-9124.patch > > > This issue is similar to HADOOP-7153. It was found when using MRUnit - see > MRUNIT-158, specifically > https://issues.apache.org/jira/browse/MRUNIT-158?focusedCommentId=13501985&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13501985 > -- > o.a.h.io.SortedMapWritable implements the java.util.Map interface, however it > does not define an implementation of the equals() or hashCode() methods; > instead the default implementations in java.lang.Object are used. > This violates the contract of the Map interface which defines different > behaviour for equals() and hashCode() than Object does. More information > here: > http://download.oracle.com/javase/6/docs/api/java/util/Map.html#equals(java.lang.Object) > The practical consequence is that SortedMapWritables containing equal entries > cannot be compared properly. We were bitten by this when trying to write an > MRUnit test for a Mapper that outputs MapWritables; the MRUnit driver cannot > test the equality of the expected and actual MapWritable objects. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira