[ https://issues.apache.org/jira/browse/HADOOP-9258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13565623#comment-13565623 ]
Steve Loughran commented on HADOOP-9258: ---------------------------------------- Tom the S3 failures are bugs there, the rename one being more serious, as it will lose data (after the rename, the parent dir is deleted). I don't know enough about the code there to fix fast -can you do it?. FWIW, the swift:// test for child-ness was trivial: {code} public static boolean isChildOf(SwiftObjectPath parent, SwiftObjectPath possibleChild) { return possibleChild.getObject().startsWith(parent.getObject() + "/"); } {code} I'm not going to do Local FS test with this once this is in I plan to write some Junit4 tests alongside this contract to be even more rigorous. > Add stricter tests to FileSystemContractTestBase > ------------------------------------------------ > > Key: HADOOP-9258 > URL: https://issues.apache.org/jira/browse/HADOOP-9258 > Project: Hadoop Common > Issue Type: Improvement > Components: test > Affects Versions: 1.1.1, 2.0.3-alpha > Reporter: Steve Loughran > Assignee: Steve Loughran > Attachments: HADOOP-9528-2.patch, HADOOP-9528.patch > > > The File System Contract contains implicit assumptions that aren't checked in > the contract test base. Add more tests to define the contract's assumptions > more rigorously for those filesystems that are tested by this (not Local, BTW) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira