[ 
https://issues.apache.org/jira/browse/HADOOP-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13567776#comment-13567776
 ] 

Chris Nauroth commented on HADOOP-9265:
---------------------------------------

I applied the patch locally and verified that it fixed the new tests from 
HADOOP-9258.

{code}
-    InputStream in = get(pathToKey(path), true);
+    String key = pathToKey(path);
+    if (isRoot(key)) {
+      return true;
+    }
+    InputStream in = get(key, true);
{code}

With this change, a query for root always resolves locally without interacting 
with S3.  This could mask some other kinds of S3 errors, such as AccessDenied, 
ExpiredToken, or NoSuchBucket.  Is that a concern?

                
> S3 blockstore filesystem breaks part of the Filesystem contract
> ---------------------------------------------------------------
>
>                 Key: HADOOP-9265
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9265
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/s3
>    Affects Versions: 1.1.1, 3.0.0
>            Reporter: Steve Loughran
>            Assignee: Tom White
>         Attachments: HADOOP-9265.patch
>
>
> The extended tests of HADOOP-9258 show that s3 is failing things which we 
> always expected an FS to do
> # {{getFileStatus("/")}} to return a {{FileStatus}} -currently it returns a 
> {{FileNotFoundException}}.
> # {{rename("somedir","somedir/childdir")}} to fail. currently it returns true 
> after deleting all the data in {{somedir/}}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to