[ 
https://issues.apache.org/jira/browse/HADOOP-8921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13569987#comment-13569987
 ] 

Chris Nauroth commented on HADOOP-8921:
---------------------------------------

Thanks, Giri.  This makes sense.  For my part, I was really just looking for a 
way to run "ant clean package" on Mac without triggering autoreconf and the 
other native build steps.  Moving these from depends to antcalls inside 
compile-core-native accomplishes the same goal, and like you said, it preserves 
the behavior of not needing to set the compile.native property when you're 
already calling the targets related to native build.

Regarding task-controller, the difficulty is that task-controller is called as 
a subant of package, which makes it difficult to test the package target on 
Mac, where task-controller fails to compile.  Could we set this up in a way 
similar to compile-native, which calls compile-core-native, and explicitly 
turns on the compile.native parameters?  Then, inclusion of task-controller 
would be controlled by the compile.native flag when running "ant package", but 
users who run "ant task-controller" would still get the existing behavior 
without needing to pass the extra parameter.  (Then, there would be no need to 
mark this "incompatible".)

                
> ant build.xml in branch-1 ignores -Dcompile.native
> --------------------------------------------------
>
>                 Key: HADOOP-8921
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8921
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.2.0
>         Environment: Mac OS X 10.7.4
>            Reporter: Gopal V
>            Priority: Trivial
>              Labels: ant, autoconf, patch
>         Attachments: HADOOP-8921.4.patch, HADOOP-8921.5.patch, 
> hadoop-8921.6.patch
>
>
> ant -Dcompile.native=false still runs autoconf and libtoolize
> According to ant 1.8 manual, any <target if> conditions are checked only 
> after the dependencies are run through. The current if condition in code 
> fails to prevent the autoconf/libtool components from running.
> Fixing it by moving the if condition up into the "compile-native" target and 
> changing it to a param substitution instead of being evaluated as a condition.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to