[ https://issues.apache.org/jira/browse/HADOOP-9330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13585300#comment-13585300 ]
Luke Lu commented on HADOOP-9330: --------------------------------- bq. Do we really want to enforce subclassing? No, you can use the @Test(timeout=seconds) just fine. You can add the default per test timeout rule to any test class as well. TestBase with a per test default timeout is just a convenience. bq. if your test case has timed out then it will terminate the whole class run, won't it? Please read the comments on HADOOP-9112 to find out why this is not desirable. > Add custom JUnit4 test runner with configurable timeout > ------------------------------------------------------- > > Key: HADOOP-9330 > URL: https://issues.apache.org/jira/browse/HADOOP-9330 > Project: Hadoop Common > Issue Type: Test > Components: test > Affects Versions: 3.0.0 > Reporter: Steve Loughran > > HADOOP-9112 has added a requirement for all new test methods to declare a > timeout, so that jenkins/maven builds will have better information on a > timeout. > Hard coding timeouts into tests is dangerous as it will generate spurious > failures on slower machines/networks and when debugging a test. > I propose providing a custom JUnit4 test runner that test cases can declare > as their test runner; this can provide timeouts specified at run-time, rather > than in-source. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira