[
https://issues.apache.org/jira/browse/HADOOP-9227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13613677#comment-13613677
]
Hudson commented on HADOOP-9227:
--------------------------------
Integrated in Hadoop-Yarn-trunk #167 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/167/])
HADOOP-9258 Add stricter tests to FileSystemContractTestBase (includes
fixes for production code HADOOP-9261 & HADOOP-9265 and test enhancements
HADOOP-9228, HADOOP-9227 & HADOOP-9259) (Revision 1460646)
Result = SUCCESS
stevel : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1460646
Files :
* /hadoop/common/trunk/hadoop-common-project/hadoop-common/CHANGES.txt
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/s3/Jets3tFileSystemStore.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/s3/S3FileSystem.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/s3native/NativeS3FileSystem.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/FileSystemContractBaseTest.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/s3/InMemoryFileSystemStore.java
*
/hadoop/common/trunk/hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/s3native/NativeS3FileSystemContractBaseTest.java
> FileSystemContractBaseTest doesn't test filesystem's mkdir/isDirectory()
> logic rigorously enough
> ------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9227
> URL: https://issues.apache.org/jira/browse/HADOOP-9227
> Project: Hadoop Common
> Issue Type: Improvement
> Components: fs
> Affects Versions: 3.0.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Trivial
> Fix For: 3.0.0
>
>
> The {{FileSystemContractBaseTest.mkdirs()}} asserts that a newly created
> directory is true, but way of {{FileStatus.isFile()}}, but doesn't assert
> that the directory is a dir by way of {{FileStatus.isDir()}}.
> The assertion used is slightly weaker, as the {{isFile()}} test is actually
> {{!isdir && !isSymlink()}}. if an implementation of {{FileSystem.mkdirs()}}
> created symlinks then the test would still pass.
> There is one test that looks at the {{isDirectory()}} logic,
> {{testMkdirsWithUmask()}} -but as that test is skipped for the s3
> filesystems, it is possible for those filesystems (or similar) to not have
> their directory creation logic stressed enough.
> The fix would be a trivial single line.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
