[ 
https://issues.apache.org/jira/browse/HADOOP-9437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-9437:
----------------------------------

    Attachment: HADOOP-9437.2.patch

{quote}
Can you please check if the two are compatible?
{quote}

Ivan, thank you for asking about this.  I had thought that the two were 
compatible at least for the rename function (though not all CRT functions).  
Your question prompted me to double-check, and it turns out that I was 
mistaken.  They are not compatible.

Here is a new version of the patch that uses conditional compilation to pass 
the return value of {{GetLastError}} to {{throw_ioe}} when running on Windows.  
I retested this on Windows and Linux with native build.  I confirmed that 
{{rename}} is setting the value of {{GetLastError}} when it fails.

                
> TestNativeIO#testRenameTo fails on Windows due to assumption that POSIX errno 
> is embedded in NativeIOException
> --------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-9437
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9437
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 3.0.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-9437.1.patch, HADOOP-9437.2.patch
>
>
> HDFS-4428 added a detailed error message for failures to rename files by 
> embedding the POSIX errno in the {{NativeIOException}}.  On Windows, the 
> mapping of errno is not performed, so the errno enum value will not be 
> present in the {{NativeIOException}}.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to