[ 
https://issues.apache.org/jira/browse/HADOOP-9222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jason Lowe updated HADOOP-9222:
-------------------------------

    Assignee: Vadim Bondarev
      Status: Open  (was: Patch Available)

Thanks for the patch, Vadim.  Overall it looks good.  Just a small nit similar 
to HADOOP-9233 that the {{BytesGenerator}} class can be replaced with a static 
function that simply returns a new byte array filled with a series of 
Random.nextInt(16).

Also, would it be better to use {{Lz4Codec.isNativeCodeLoaded}} rather than the 
{{NativeCodeLoader}} method directly?
                
> Cover package with org.apache.hadoop.io.lz4 unit tests
> ------------------------------------------------------
>
>                 Key: HADOOP-9222
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9222
>             Project: Hadoop Common
>          Issue Type: Test
>    Affects Versions: 2.0.3-alpha, 3.0.0, 0.23.6
>            Reporter: Vadim Bondarev
>            Assignee: Vadim Bondarev
>         Attachments: HADOOP-9222-branch-0.23-a.patch, 
> HADOOP-9222-branch-0.23-b.patch, HADOOP-9222-branch-2-a.patch, 
> HADOOP-9222-branch-2-b.patch, HADOOP-9222-trunk-a.patch, 
> HADOOP-9222-trunk-b.patch
>
>
> Add test class TestLz4CompressorDecompressor with method for Lz4Compressor, 
> Lz4Decompressor testing 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to