[ 
https://issues.apache.org/jira/browse/HADOOP-9450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13632637#comment-13632637
 ] 

Harsh J commented on HADOOP-9450:
---------------------------------

{quote}
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{quote}

Patch changes the script; no existing tests are present. Patch was tested by 
running in the shell's debug mode (bash -x) for Linux by me to observe 
difference in built CLASSPATH based on the HADOOP_USER_CLASSPATH_FIRST toggle 
and was also verified by Chris for behavior on Windows manually.
                
> HADOOP_USER_CLASSPATH_FIRST is not honored; CLASSPATH is PREpended instead of 
> APpended
> --------------------------------------------------------------------------------------
>
>                 Key: HADOOP-9450
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9450
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Mitch Wyle
>         Attachments: HADOOP-9450-branch-1.patch, 
> HADOOP-9450-branch-1-win.patch, HADOOP-9450.patch, HADOOP-9450.patch
>
>
> On line 133 of the hadoop shell wrapper, CLASSPATH is set as:
> CLASSPATH=${CLASSPATH}:${HADOOP_CLASSPATH}
> Notice that the built-up CLASSPATH, along with all the libs and unwanted JARS 
> are pre-pended BEFORE the user's HADOOP_CLASSPATH.  Therefore there is no way 
> to put your own JARs in front of those that the hadoop wrapper script sets.
> We propose a patch that reverses this order.  Failing that, we would like to 
> add a command line option to override this behavior and enable a user's JARs 
> to be found before the wrong ones in the Hadoop library paths.
> We always welcome your opinions.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to