[ 
https://issues.apache.org/jira/browse/HADOOP-9043?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-9043:
----------------------------------

    Attachment: HADOOP-9043.trunk.4.patch

Here is version 4 of the trunk patch, with the following changes since last 
time:

# {{RawLocalFs#getPathWithoutSchemeAndAuthority}} now returns {{File}} instead 
of {{String}}.
# Added comment in {{TestLocalFSFileContextSymlink}} stating that dangling 
symlinks are not supported on Windows.
# Added tests in {{TestWinUtils}} for asserting that winutils symlink will 
return an error if attempting to pass it paths with forward slashes in either 
link or target.  The earlier version of the symlink.c patch only checked 
target, so I also changed that to check both link and target.

How does this look?  Once I have +1 on the trunk patch, I'll prep the 
equivalent branch-1-win patch.
                
> winutils can create unusable symlinks
> -------------------------------------
>
>                 Key: HADOOP-9043
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9043
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 3.0.0, 1-win
>            Reporter: Chris Nauroth
>            Assignee: Arpit Agarwal
>             Fix For: 3.0.0, 1-win
>
>         Attachments: HADOOP-9043.branch-1.2.patch, 
> HADOOP-9043.branch-1-win.patch, HADOOP-9043.trunk.2.patch, 
> HADOOP-9043.trunk.3.patch, HADOOP-9043.trunk.4.patch, HADOOP-9043.trunk.patch
>
>
> In general, the winutils symlink command rejects attempts to create symlinks 
> targeting a destination file that does not exist.  However, if given a 
> symlink destination with forward slashes pointing at a file that does exist, 
> then it creates the symlink with the forward slashes, and then attempts to 
> open the file through the symlink will fail.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to