[ 
https://issues.apache.org/jira/browse/HADOOP-9290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-9290:
----------------------------------

    Attachment: HADOOP-9290.3.patch

Thanks for the reviews, Arpit and Ivan.  I'm attaching version 3 of the patch.  
This still might not be the final version, but I wanted to get you something to 
add the comment and fix the contrib problem ASAP.

{quote}
It seems that the currently defined value for LD_LIBRARY_PATH is invalid.
{quote}

I think the current values are correct, and my test runs on Linux were 
successfully loading libhadoop.so.  On Windows, the build puts hadoop.dll into 
target/bin.  On Linux, the build puts libhadoop.so into 
target/native/target/usr/local/lib.

{quote}
hadoop-project/pom.xml: Assuming that we specified a valid value for 
LD_LIBRARY_PATH above, the following section might not be needed
{quote}

I think we need a separate definition for PATH, because Windows doesn't use 
LD_LIBRARY_PATH, right?  Perhaps the split of definitions between the main part 
of the pom.xml and the native-win profile is a bit confusing.  I'll see if I 
can do anything to improve that.

{quote}
Might make sense to either remove hadoop.common.build.dir or use it for both 
winutils.exe and hadoop.dll
{quote}

My goal with hadoop.common.build.dir was to prevent the need for child modules 
to duplicate the whole maven-surefire-plugin <configuration> stanza.  I had 
forgotten that we already started down that path for HADOOP_HOME.  I think I 
can simplify so that the hadoop.common.build.dir override handles both needs, 
and there is less pom.xml configuration to maintain in child modules.  I'll 
test this and report back.
                
> Some tests cannot load native library
> -------------------------------------
>
>                 Key: HADOOP-9290
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9290
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: build, native
>    Affects Versions: 3.0.0
>            Reporter: Arpit Agarwal
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-9290.2.patch, HADOOP-9290.3.patch, 
> HADOOP-9290.patch
>
>
> Some tests are unable to load the native DLL on Windows. The culprit appears 
> to be an incorrect PATH configuration for the native-win profile in 
> hadoop-project/pom.xml.
> {code:xml}
>     <profile>
>       <id>native-win</id>
>       <activation>
>         <os>
>           <family>Windows</family>
>         </os>
>       </activation>
>       <build>
>         <plugins>
>           <plugin>
>             <groupId>org.apache.maven.plugins</groupId>
>             <artifactId>maven-surefire-plugin</artifactId>
>             <configuration>
>               <environmentVariables>
>                 <!-- Specify where to look for the native DLL on Windows -->
>                 
> <PATH>${env.PATH};${basedir}\..\..\hadoop-common-project\hadoop-common\target\bin;</PATH>
>               </environmentVariables>
>             </configuration>
>           </plugin>
>         </plugins>
>       </build>
>     </profile>
> {code}
> This is evaluated independently by each project and the relative path is not 
> always correct.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to