[ 
https://issues.apache.org/jira/browse/HADOOP-9523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13645734#comment-13645734
 ] 

Aaron T. Myers commented on HADOOP-9523:
----------------------------------------

Good point re: KerberosUtil being in hadoop-auth. That's a bit of a bummer, and 
suggests that we should perhaps move the PlatformName class into the 
highest-level Maven module we have, but that's a more involved change so no 
need to do that in this JIRA if you don't want to.

One little nit on the latest patch (sorry, should have made this clear earlier) 
- please separate the words in the new constants using underscores ("_") 
instead of just running them together. For example, it should be 
"JAVA_VENDOR_NAME" not "JAVAVENDORNAME".

+1 once this is addressed.
                
> Provide a generic IBM java vendor flag in PlatformName.java to support 
> non-Sun JREs
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-9523
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9523
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 2.0.4-alpha
>            Reporter: Tian Hong Wang
>            Assignee: Tian Hong Wang
>              Labels: patch
>         Attachments: HADOOP-9523.patch, HADOOP-9523-v1.patch
>
>
> There are several different points between Sun jdk & IBM jdk, so there is a 
> need to provide a generic IBM java vendor flag. So enhance PlatformName.java 
> to add Java vendor information.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to