[
https://issues.apache.org/jira/browse/HADOOP-9483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpit Agarwal updated HADOOP-9483:
----------------------------------
Attachment: HADOOP-9483.003.patch
Thanks for the quick review Ivan!
I have addressed all your feedback except for the below.
{quote}
2. To be able to handle input paths longer then MAX_PATH I think you'll have to
add a long path prefix before calling into CreateFile API. We already have an
API available in winutils to convert to a long path, check what we do on other
places.
{quote}
I am not sure it is possible to get a path longer than MAX_PATH as input to
Readlink since winutils is invoked via the shell. The situation you have
handled elsewhere is when the path is passed in via JNI. Please let me know if
I am wrong.
{quote}
Should this be if argc != 2?
{quote}
Deliberate for consistency with POSIX readlink. All extra arguments are ignored.
{quote}
I would also rather use a winerror code dword throughout the function as an
indicator that something failed (instead of the 'succeeded' boolean) and at the
function end check if it is equal to ERROR_SUCCESS or not
{quote}
It seems to complicates the state, especially since we don't really care about
the exact error code for most Win32 calls here. However I don't feel too
strongly about it so let me know what you think.
{quote}
9. Should we integrate the readlink functionality with RawLocalFs in this
Jira?
{quote}
That is intended to be fixed in HADOOP-9527.
> winutils support for readlink command
> -------------------------------------
>
> Key: HADOOP-9483
> URL: https://issues.apache.org/jira/browse/HADOOP-9483
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 3.0.0
> Reporter: Chris Nauroth
> Assignee: Arpit Agarwal
> Attachments: HADOOP-9483.003.patch, HADOOP-9483.patch,
> HADOOP-9483.patch
>
>
> The current codebase relies on the Unix readlink command to determine the
> target of a symlink on the local file system. winutils currently does not
> support this functionality on Windows. Adding the command to winutils will
> prevent the need to use GnuWin32 or Cygwin for readlink support.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
