[
https://issues.apache.org/jira/browse/HADOOP-9346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13656458#comment-13656458
]
Harsh J commented on HADOOP-9346:
---------------------------------
{quote}
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
{quote}
The build passing is the test for this change - as the {{bin/protoc}} on the
current build machines are that of a lower version than the bumped jar
dependency.
Besides that, both 2.5 and 2.4 protoc builds have been locally tested by me
manually.
> Upgrading to protoc 2.5.0 fails the build
> -----------------------------------------
>
> Key: HADOOP-9346
> URL: https://issues.apache.org/jira/browse/HADOOP-9346
> Project: Hadoop Common
> Issue Type: Task
> Components: build
> Affects Versions: 3.0.0
> Reporter: Harsh J
> Assignee: Harsh J
> Priority: Minor
> Labels: protobuf
> Attachments: HADOOP-9346.patch
>
>
> Reported over the impala lists, one of the errors received is:
> {code}
> src/hadoop-common-project/hadoop-common/target/generated-sources/java/org/apache/hadoop/ha/proto/ZKFCProtocolProtos.java:[104,37]
> can not find symbol.
> symbol： class Parser
> location： package com.google.protobuf
> {code}
> Worth looking into as we'll eventually someday bump our protobuf deps.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
