[ 
https://issues.apache.org/jira/browse/HADOOP-9573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13668509#comment-13668509
 ] 

Giridharan Kesavan commented on HADOOP-9573:
--------------------------------------------

This new version of the test-patch has the following changes. 
* Added support for git 
* Figures out the path to grep, svn, patch and curl binary  
* Removed dependency on jdk5 
* Uses getopt to parse cmd line args
* Takes patch attachment-id from the jira. 
* And more cleanup.

Tested hadoop-9573.patch from the cmd line without posting on any apache jira 
and test-patch seem to work fine. 

Below is the cmd line to start the test-patch in developer and jenkins mode:
Developer Mode:
{code}
ant test-patch -Dpatch.file=<patch file name with path> -Dforrest.home=<forrest 
home> \
   -Dfindbugs.home=<findbugs home> -Declipse.home=<findbugs home> \
   -Dpatch.dir=<tmp dir to write logs and patch>
{code}
Jenkins Mode:
{code}
ant jenkins-test-patch -Dfindbugs.home=<findbugs home> 
-Dforrest.home=<forrest.home> \
   -Dpatch.dir=<tmp dir for logging downloading patch> -Djiracli.cmd=<path to 
jira cli tool> \
   -Djiranum=<jira #> -Dattachid=<attachment id to test>
{code}

For now the plan is to create a jenkin's job and let the developers trigger 
test-patch on branch-1 by passing in the attachment-id and jira number. Once 
the admin job is setup, test-patch job will be configured to run automatically. 

[~mattf] Thanks for the review comments.
                
> Fix test-patch script to work with the enhanced PreCommit-Admin script.
> -----------------------------------------------------------------------
>
>                 Key: HADOOP-9573
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9573
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: build
>    Affects Versions: 1.0.3
>            Reporter: Giridharan Kesavan
>            Assignee: Giridharan Kesavan
>         Attachments: 
> 0001-Fix-test-patch-scrit-to-work-with-the-enhanced-PreCo.patch, 
> hadoop-9573.patch
>
>
> test-patch script currently take the latest available patch for a given jira 
> and performs the test. This jira is to enhance test-patch script to take 
> attachment-id of a patch as an input and perform the tests using that 
> attachment-id

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to