[ 
https://issues.apache.org/jira/browse/HADOOP-9623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13682321#comment-13682321
 ] 

Tom White commented on HADOOP-9623:
-----------------------------------

Overall it looks fine. Do Jets3tNativeS3FileSystemContractTest and 
Jets3tS3FileSystemContractTest pass with this change? They are live tests run 
against the real S3 service and are not run by default. You'll need to put S3 
credentials into 
hadoop-common-project/hadoop-common/src/test/resources/core-site.xml to run 
them.

Nit: catch blocks should be on the same line as the preceding brace.
                
> Update jets3t dependency
> ------------------------
>
>                 Key: HADOOP-9623
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9623
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 3.0.0, 2.1.0-beta
>            Reporter: Timothy St. Clair
>              Labels: maven
>         Attachments: HADOOP-9623.patch
>
>
> Current version referenced in pom is 0.6.1 (Aug 2008), updating to 0.9.0 
> enables mvn-rpmbuild to build against system dependencies. 
> http://jets3t.s3.amazonaws.com/RELEASE_NOTES.html

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to