[
https://issues.apache.org/jira/browse/HADOOP-9515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13683804#comment-13683804
]
Brandon Li commented on HADOOP-9515:
------------------------------------
Thanks for the review!
The new patch addressed the comments.
{quote}Nfs3FileAttributes - member variables can be made final and setters can
be removed. Some of the constructors and getters do not seem necessary as well.
Not sure if it is required for HDFS NFS implementation?{quote}
These methods are used by HDFS-NFS implementation.
{quote} There is TODO in TestNfs3Simple. This does not seem like a unit test.
Can you cover this into unit test and also add javadoc describing what the test
does{quote}
Sorry, I added a wrong test. It's replaced by TestNfsTime.java in the new
patch.
{quote} Please add more unit tests{quote}
This patch is mostly some interface and data structure definition. Even though,
more unit tests are needed. I will file subsequent JIRAs to address this.
> Add general interface for NFS and Mount
> ---------------------------------------
>
> Key: HADOOP-9515
> URL: https://issues.apache.org/jira/browse/HADOOP-9515
> Project: Hadoop Common
> Issue Type: New Feature
> Affects Versions: 3.0.0
> Reporter: Brandon Li
> Assignee: Brandon Li
> Attachments: HADOOP-9515.1.patch, HADOOP-9515.2.patch,
> HADOOP-9515.3.patch, HADOOP-9515.4.patch, HADOOP-9515.5.patch
>
>
> These is the general interface implementation for NFS and Mount protocol,
> e.g., some protocol related data structures and etc. It doesn't include the
> file system specific implementations.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
