[ https://issues.apache.org/jira/browse/HADOOP-9439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13688385#comment-13688385 ]
Hadoop QA commented on HADOOP-9439: ----------------------------------- {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12588669/HADOOP-9439.008.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-common-project/hadoop-common: org.apache.hadoop.ipc.TestSaslRPC {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/2677//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/2677//console This message is automatically generated. > JniBasedUnixGroupsMapping: fix some crash bugs > ---------------------------------------------- > > Key: HADOOP-9439 > URL: https://issues.apache.org/jira/browse/HADOOP-9439 > Project: Hadoop Common > Issue Type: Bug > Components: native > Affects Versions: 2.0.4-alpha > Reporter: Colin Patrick McCabe > Assignee: Colin Patrick McCabe > Priority: Minor > Attachments: HADOOP-9439.001.patch, HADOOP-9439.003.patch, > HADOOP-9439.005.patch, HADOOP-9439.006.patch, HADOOP-9439.007.patch, > HADOOP-9439.008.patch, HDFS-4640.002.patch > > > JniBasedUnixGroupsMapping has some issues. > * sometimes on error paths variables are freed prior to being initialized > * re-allocate buffers less frequently (can reuse the same buffer for multiple > calls to getgrnam) > * allow non-reentrant functions to be used, to work around client bugs > * don't throw IOException from JNI functions if the JNI functions do not > declare this checked exception. > * don't bail out if only one group name among all the ones associated with a > user can't be looked up. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira