[ 
https://issues.apache.org/jira/browse/HADOOP-9776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13720841#comment-13720841
 ] 

Chuan Liu commented on HADOOP-9776:
-----------------------------------

The change looks good to me. Probably worth adding a unit test case to Hadoop 
to cover the scenario.
                
> HarFileSystem.listStatus() returns "har://<scheme>-localhost:/..." if port 
> number is empty
> ------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-9776
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9776
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 3.0.0, 2.1.0-beta
>            Reporter: shanyu zhao
>         Attachments: HADOOP-9776.patch
>
>
> If the given har URI is "har://<scheme>-localhost/usr/my.har/a", the result 
> of HarFileSystem.listStatus() will have a ":" appended after localhost, like 
> this: "har://<scheme>-localhost:/usr/my.har/a". it should return 
> "har://<scheme>-localhost/usr/my.bar/a" instead.
> This creates problem when running a hive unit test TestCliDriver 
> (archive_excludeHadoop20.q), generating the following error:
>       java.io.IOException: cannot find dir = 
> har://pfile-localhost:/GitHub/hive-monarch/build/ql/test/data/warehouse/tstsrcpart/ds=2008-04-08/hr=12/data.har/000000_0
>  in pathToPartitionInfo: 
> [pfile:/GitHub/hive-monarch/build/ql/test/data/warehouse/tstsrcpart/ds=2008-04-08/hr=11,
>  
> har://pfile-localhost/GitHub/hive-monarch/build/ql/test/data/warehouse/tstsrcpart/ds=2008-04-08/hr=12/data.har]
>           [junit]     at 
> org.apache.hadoop.hive.ql.io.HiveFileFormatUtils.getPartitionDescFromPathRecursively(HiveFileFormatUtils.java:298)
>           [junit]     at 
> org.apache.hadoop.hive.ql.io.HiveFileFormatUtils.getPartitionDescFromPathRecursively(HiveFileFormatUtils.java:260)
>           [junit]     at 
> org.apache.hadoop.hive.ql.io.CombineHiveInputFormat$CombineHiveInputSplit.<init>(CombineHiveInputFormat.java:104)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to