[ https://issues.apache.org/jira/browse/HADOOP-9778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13720981#comment-13720981 ]
Colin Patrick McCabe commented on HADOOP-9778: ---------------------------------------------- Here's an idea: why not make the validation configurable? I don't think there is a great demand for zany user names, and if we shell-expand them in even one place, we could have problems. Probably the default validation pattern for windows should be different and include spaces. I haven't actually found a place where we shell expand user names (despite its name, ShellBasedUnixGroupsMapping doesn't actually create a shell). > Remove user name and group name validation logic from chown and chgrp shell > commands. > ------------------------------------------------------------------------------------- > > Key: HADOOP-9778 > URL: https://issues.apache.org/jira/browse/HADOOP-9778 > Project: Hadoop Common > Issue Type: Improvement > Components: fs > Affects Versions: 3.0.0, 2.3.0 > Reporter: Chris Nauroth > Priority: Minor > > The chown and chgrp shell commands enforce a valid set of characters for user > names and group names. The validation rules for user names and group names > vary across different OSes, so this is a portability problem and a > maintenance burden. It requires us to change the code every time we discover > a difference in the rules. I propose that we remove this validation logic > and instead pass through input user names and group names to the OS. We can > handle error reporting by catching errors returned from the OS. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira