[ 
https://issues.apache.org/jira/browse/HADOOP-9779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tsuyoshi OZAWA updated HADOOP-9779:
-----------------------------------

    Attachment: HADOOP-9779.1.patch

Added RpcConstants.CLIENT_ID_LENGTH and changed RetryCache to use 
CLIENT_ID_LENGTH .
                
> create constant RpcConstants.CLIENT_ID_LENGTH rather than hard-coding 16 
> everywhere
> -----------------------------------------------------------------------------------
>
>                 Key: HADOOP-9779
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9779
>             Project: Hadoop Common
>          Issue Type: Bug
>            Reporter: Colin Patrick McCabe
>            Priority: Minor
>         Attachments: HADOOP-9779.1.patch
>
>
> We should create a constant RpcConstants.CLIENT_ID_LENGTH rather than 
> hard-coding the number 16 everywhere.
> Sun Java coding style convention 10.3:
> bq. Numerical constants (literals) should not be coded directly, except for 
> -1, 0, and 1, which can appear in a for loop as counter values.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to