[ https://issues.apache.org/jira/browse/HADOOP-9551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Nauroth updated HADOOP-9551: ---------------------------------- Hadoop Flags: Reviewed +1 for the patch. Thanks, Ivan! I have a couple of additional notes related to this patch, but none of this needs to prevent committing the current patch: # I think it would be good to backport {{TestDiskChecker}} to branch-1 and branch-1-win. I've filed HADOOP-9843 for this. # We want to use {{assumeTrue}} for skipping tests that don't apply to the current platform. I didn't recommend making the change in this patch, because trunk currently uses {{if (WINDOWS)}} for this too. Cross-branch maintenance will be easier if we keep these the same. We already have HADOOP-9427 to track cleaning those up. I updated its Target Version to include branch-1-win. We can clean up both branches in the scope of that issue. > Backport common utils introduced with HADOOP-9413 to branch-1-win > ----------------------------------------------------------------- > > Key: HADOOP-9551 > URL: https://issues.apache.org/jira/browse/HADOOP-9551 > Project: Hadoop Common > Issue Type: Bug > Affects Versions: 1-win > Reporter: Ivan Mitic > Assignee: Ivan Mitic > Attachments: HADOOP-9551.branch-1-win.common.2.patch, > HADOOP-9551.branch-1-win.common.3.patch, > HADOOP-9551.branch-1-win.common.4.patch > > > Branch-1-win has the same set of problems described in HADOOP-9413. With this > Jira I plan to prepare a branch-1-win compatible patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira