[
https://issues.apache.org/jira/browse/HADOOP-9505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13736866#comment-13736866
]
Hadoop QA commented on HADOOP-9505:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12597468/HADOOP-9505.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 2 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2966//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2966//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2966//console
This message is automatically generated.
> Specifying checksum type to NULL can cause write failures with AIOBE
> --------------------------------------------------------------------
>
> Key: HADOOP-9505
> URL: https://issues.apache.org/jira/browse/HADOOP-9505
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.1.0-beta
> Reporter: Uma Maheswara Rao G
> Assignee: Vinay
> Priority: Minor
> Attachments: HADOOP-9505.patch
>
>
> I have created a file with checksum disable option and I am seeing
> ArrayIndexOutOfBoundsException.
> {code}
> out = fs.create(fileName, FsPermission.getDefault(), flags, fs.getConf()
> .getInt("io.file.buffer.size", 4096), replFactor, fs
> .getDefaultBlockSize(fileName), null, ChecksumOpt.createDisabled());
> {code}
> See the trace here:
> {noformat}
> java.lang.ArrayIndexOutOfBoundsException: 0
> at org.apache.hadoop.fs.FSOutputSummer.int2byte(FSOutputSummer.java:178)
> at
> org.apache.hadoop.fs.FSOutputSummer.writeChecksumChunk(FSOutputSummer.java:162)
> at org.apache.hadoop.fs.FSOutputSummer.write1(FSOutputSummer.java:106)
> at org.apache.hadoop.fs.FSOutputSummer.write(FSOutputSummer.java:92)
> at
> org.apache.hadoop.fs.FSDataOutputStream$PositionCache.write(FSDataOutputStream.java:54)
> at java.io.DataOutputStream.write(DataOutputStream.java:90)
> at org.apache.hadoop.hdfs.DFSTestUtil.createFile(DFSTestUtil.java:261)
> at
> org.apache.hadoop.hdfs.TestReplication.testBadBlockReportOnTransfer(TestReplication.java:174)
> {noformat}
> In FSOutputSummer#int2byte will not check any bytes length, so, do you think
> we have to to check the length then only we call this in CRC NULL case, as
> there will not be any checksum bytes?
> {code}
> static byte[] int2byte(int integer, byte[] bytes) {
> bytes[0] = (byte)((integer >>> 24) & 0xFF);
> bytes[1] = (byte)((integer >>> 16) & 0xFF);
> bytes[2] = (byte)((integer >>> 8) & 0xFF);
> bytes[3] = (byte)((integer >>> 0) & 0xFF);
> return bytes;
> }
> {code}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
