[ 
https://issues.apache.org/jira/browse/HADOOP-8704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13760247#comment-13760247
 ] 

Alejandro Abdelnur commented on HADOOP-8704:
--------------------------------------------

Glad to help. LGTM, +1 pending test-patch results.

One last suggested naming change (leaving that to you). The patch is using 
log4j.logger.http.requests.hdfs/datanode/cluster/jobhistory/node. Instead, 
shouldn't we use the proper service name? 
namenode/datanode/resourcemanager/jobhistory/nodemanager/... ?

                
> add request logging to jetty/httpserver
> ---------------------------------------
>
>                 Key: HADOOP-8704
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8704
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 0.23.3, 2.0.0-alpha
>            Reporter: Thomas Graves
>            Assignee: Jonathan Eagles
>         Attachments: HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, 
> HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch, HADOOP-8704.patch
>
>
> We have been requested to log all the requests coming into Jetty/HttpServer 
> for security and auditing purposes. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to