[
https://issues.apache.org/jira/browse/HADOOP-9966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13771232#comment-13771232
]
Hadoop QA commented on HADOOP-9966:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12603911/HADOOP-9966.002.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-nfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3109//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3109//console
This message is automatically generated.
> Refactor XDR code into XDRReader and XDRWriter
> ----------------------------------------------
>
> Key: HADOOP-9966
> URL: https://issues.apache.org/jira/browse/HADOOP-9966
> Project: Hadoop Common
> Issue Type: Improvement
> Components: nfs
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Attachments: HADOOP-9966.000.patch, HADOOP-9966.001.patch,
> HADOOP-9966.002.patch
>
>
> Several methods in the current XDR class have ambiguous semantics. For
> example, Size() returns the actual size of internal byte array. The actual
> size of current buffer, is also affected by read requests, which pull data
> out of the buffer.
> These ambiguous semantics makes removing redundant copies on the NFS paths
> difficult.
> This JIRA proposes to decompose the responsibilities of XDR into two separate
> class: XDRReader and XDRWriter. The overall designs should closely follow
> Java's *Reader / *Writer classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
