[ https://issues.apache.org/jira/browse/HADOOP-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13794633#comment-13794633 ]
Chris Nauroth commented on HADOOP-10040: ---------------------------------------- I just made one more commit related to this. It turns out that while correcting this I accidentally reverted one line from native.vcxproj to compile lz4hc.c. This ultimately caused unresolved external symbol errors in the Windows native build. I didn't catch it earlier, because I did my testing on branch-2.2, and lz4hc.c only exists on trunk and branch-2. I re-committed the native.vcxproj change shown in HADOOP-9319 to trunk and branch-2. Sorry if this caused churn for anyone. > hadoop.cmd in UNIX format and would not run by default on Windows > ----------------------------------------------------------------- > > Key: HADOOP-10040 > URL: https://issues.apache.org/jira/browse/HADOOP-10040 > Project: Hadoop Common > Issue Type: Bug > Reporter: Yingda Chen > Assignee: Chris Nauroth > Fix For: 3.0.0, 2.2.1 > > > The hadoop.cmd currently checked in into hadoop-common is in UNIX format, > same as most of other src files. However, the hadoop.cmd is meant to be used > on Windows only, the fact that it is in UNIX format makes it unrunnable as is > on Window platform. > An exception shall be made on hadoop.cmd (and other cmd files for what > matters) to make sure they are in DOS format, for them to be runnable as is > when checked out from source repository. -- This message was sent by Atlassian JIRA (v6.1#6144)