[ https://issues.apache.org/jira/browse/HADOOP-10043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13794836#comment-13794836 ]
Hadoop QA commented on HADOOP-10043: ------------------------------------ {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12608397/HADOOP-10043.3.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. The javadoc tool did not generate any warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-hs hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3216//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3216//console This message is automatically generated. > Convert org.apache.hadoop.security.token.SecretManager to be an > AbstractService > ------------------------------------------------------------------------------- > > Key: HADOOP-10043 > URL: https://issues.apache.org/jira/browse/HADOOP-10043 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Tsuyoshi OZAWA > Assignee: Tsuyoshi OZAWA > Attachments: HADOOP-10043.1.patch, HADOOP-10043.2.patch, > HADOOP-10043.3.patch > > > I'm dealing with YARN-1172, a subtask of YARN-1139(ResourceManager HA related > task). The sentence as follows is a quoted from YARN-1172's my comment: > {quote} > I've found that it requires org.apache.hadoop.security.token.SecretManager to > be an AbstractService, > because both AbstractService and > org.apache.hadoop.security.token.SecretManager are abstract class and we > cannot extend both of them at the same time. > {quote} -- This message was sent by Atlassian JIRA (v6.1#6144)