[ 
https://issues.apache.org/jira/browse/HADOOP-10100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13822940#comment-13822940
 ] 

Hadoop QA commented on HADOOP-10100:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12613935/HADOOP-10100.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-minikdc.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/3288//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/3288//console

This message is automatically generated.

> MiniKDC shouldn't use apacheds-all artifact
> -------------------------------------------
>
>                 Key: HADOOP-10100
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10100
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.3.0
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>         Attachments: HADOOP-10100.patch, HADOOP-10100.patch
>
>
> The MiniKDC currently depends on the {{apacheds-all}} artifact:
> {code:xml}
>     <dependency>
>       <groupId>org.apache.directory.server</groupId>
>       <artifactId>apacheds-all</artifactId>
>       <version>2.0.0-M15</version>
>       <scope>compile</scope>
>     </dependency>
> {code}
> However, this artifact includes, inside of itself, a lot of other packages, 
> including antlr, ehcache, apache commons, and mina (you can see a full list 
> of the packages in the jar 
> [here|http://mvnrepository.com/artifact/org.apache.directory.server/apacheds-all/2.0.0-M15]).
>   This can be problematic if other projects (e.g. Oozie) try to use MiniKDC 
> and have a different version of one of those dependencies (in my case, 
> ehcache).  Because the packages are included inside the {{apacheds-all}} jar, 
> we can't override their version.  
> Instead, we should remove {{apacheds-all}} and use dependencies that only 
> include org.apache.directory.* packages; the other necessary dependencies 
> should be included normally.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to