[ https://issues.apache.org/jira/browse/HADOOP-10087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13844894#comment-13844894 ]
Andrew Wang commented on HADOOP-10087: -------------------------------------- Patch looks good to me, thanks for fixing this Colin. Just one comment: * Can we skip the {{goto error}} handling in hadoop_user_info_getgroups? I think that free is already handled in JniBasedUnixGroupMapping and the main by calling hadoop_user_info_free. +1 once addressed. > UserGroupInformation.getGroupNames() fails to return primary group first when > JniBasedUnixGroupsMappingWithFallback is used > --------------------------------------------------------------------------------------------------------------------------- > > Key: HADOOP-10087 > URL: https://issues.apache.org/jira/browse/HADOOP-10087 > Project: Hadoop Common > Issue Type: Bug > Components: security > Affects Versions: 2.1.0-beta, 2.2.0 > Environment: SUSE Linux Enterprise Server 11 (x86_64) > Reporter: Yu Gao > Assignee: Colin Patrick McCabe > Labels: security > Attachments: HADOOP-10087.001.patch > > > When JniBasedUnixGroupsMappingWithFallback is used as the group mapping > resolution provider, UserGroupInformation.getGroupNames() fails to return the > primary group first in the list as documented. -- This message was sent by Atlassian JIRA (v6.1.4#6159)