[
https://issues.apache.org/jira/browse/HADOOP-10269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13920121#comment-13920121
]
Daryn Sharp commented on HADOOP-10269:
--------------------------------------
Not a pest by any means. This issue is whether to log cascading and irrelevant
exceptions. For example, upon stream exceptions we usually swallow exceptions
from closing the stream. We don't care the stream failed to close (likely
attributable to the real exception that prompted the close), all we care about
is the actual stream exception.
> SaslException is completely ignored
> -----------------------------------
>
> Key: HADOOP-10269
> URL: https://issues.apache.org/jira/browse/HADOOP-10269
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.2.0
> Reporter: Ding Yuan
>
> In "org/apache/hadoop/security/SaslOutputStream.java", there is the following
> code pattern:
> {noformat}
> 172 try {
> 173 if (saslServer != null) { // using saslServer
> 174 saslToken = saslServer.wrap(inBuf, off, len);
> 175 } else { // using saslClient
> 176 saslToken = saslClient.wrap(inBuf, off, len);
> 177 }
> 178 } catch (SaslException se) {
> 179 try {
> 180 disposeSasl();
> 181 } catch (SaslException ignored) {
> 182 }
> 183 throw se;
> 184 }
> {noformat}
> On line 181, the exception thrown by disposeSasl(), which can be from
> SaslServer.dispose() or SaslClient.dispose(), is ignored completely without
> even logging it. Maybe at least log it?
> Ding
--
This message was sent by Atlassian JIRA
(v6.2#6252)
