[ 
https://issues.apache.org/jira/browse/HADOOP-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

jay vyas updated HADOOP-3679:
-----------------------------

    Attachment: HADOOP-3679.patch

Here's a first go at a patch.  This should improve the situation for all the 
instances which I was able to find in a first pass using an automated method 
followed by manual inspection of the offending classes listed above.  Let me 
know if any others I've missed.  

> calls to junit Assert::assertEquals invert arguments, causing misleading 
> error messages, other minor improvements.
> ------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-3679
>                 URL: https://issues.apache.org/jira/browse/HADOOP-3679
>             Project: Hadoop Common
>          Issue Type: Test
>          Components: test
>            Reporter: Chris Douglas
>            Priority: Minor
>         Attachments: HADOOP-3679.patch
>
>
> JUnit Assert::assertEquals takes its expected and actual arguments in a 
> particular order, but many unit tests invert them. The error message from a 
> failed assertion can be misleading.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to