[
https://issues.apache.org/jira/browse/HADOOP-10441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948238#comment-13948238
]
Tsz Wo Nicholas Sze commented on HADOOP-10441:
----------------------------------------------
Also need to update TestRetryCacheMetrics.
{code}
54: MetricsRecordBuilder rb = getMetrics("RetryCache/" + cacheName);
{code}
> Namenode metric "rpc.RetryCache/NameNodeRetryCache.CacheHit" can't be
> correctly processed by Ganglia
> ----------------------------------------------------------------------------------------------------
>
> Key: HADOOP-10441
> URL: https://issues.apache.org/jira/browse/HADOOP-10441
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 2.4.0
> Reporter: Jing Zhao
> Assignee: Jing Zhao
> Priority: Blocker
> Attachments: HADOOP-10441.000.patch
>
>
> The issue is reported by [~dsen]:
> Recently added Namenode metric "rpc.RetryCache/NameNodeRetryCache.CacheHit"
> can't be correctly processed by Ganglia because its name contains "/"
> Proposal: Namenode metric "rpc.RetryCache/NameNodeRetryCache.CacheHit" should
> be renamed to "rpc.RetryCache.NameNodeRetryCache.CacheHit"
> Here - org.apache.hadoop.ipc.metrics.RetryCacheMetrics#RetryCacheMetrics
> {code}
> RetryCacheMetrics(RetryCache retryCache) {
> name = "RetryCache/"+ retryCache.getCacheName();
> registry = new MetricsRegistry(name);
> if (LOG.isDebugEnabled()) {
> LOG.debug("Initialized "+ registry);
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
