[jira] [Commented] (HADOOP-10548) Improve FsShell xattr error handling and other fixes

[Uma Maheswara Rao G (JIRA)]

    [ 
https://issues.apache.org/jira/browse/HADOOP-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13984620#comment-13984620
 ] 

Uma Maheswara Rao G commented on HADOOP-10548:
----------------------------------------------

Thanks for the update.
I think the current test will pass and does not care what message it will 
display.
How the following test case look?
{code}
@Test
  public void testGetfattrWithInvalidEncoding() throws Exception {
    PrintStream backup = System.err;
    ByteArrayOutputStream out = new ByteArrayOutputStream();
    System.setErr(new PrintStream(out));
    try {
      runCommand(new String[] { "-getfattr", "-e", "invalid", "-n",
          "xattrname", "/file1" });
      assertTrue("getfattr should fail with \"-getfattr: Invalid/unsupported "
          + "econding option specified: en=invalid\". But the output is: "
          + out.toString(), out.toString().contains(
          "-getfattr: "
              + "Invalid/unsupported econding option specified: en=invalid"));
    } finally {
      System.setErr(backup);
    }
  }
{code}


> Improve FsShell xattr error handling and other fixes
> ----------------------------------------------------
>
>                 Key: HADOOP-10548
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10548
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>    Affects Versions: HDFS XAttrs (HDFS-2006)
>            Reporter: Andrew Wang
>            Assignee: Charles Lamb
>            Priority: Minor
>         Attachments: HADOOP-10548.1.patch, HADOOP-10548.2.patch
>
>
> A couple small remaining issues from HADOOP-10521 we should address in this 
> follow-on JIRA.



--
This message was sent by Atlassian JIRA
(v6.2#6252)