[ 
https://issues.apache.org/jira/browse/HADOOP-10567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988057#comment-13988057
 ] 

Uma Maheswara Rao G commented on HADOOP-10567:
----------------------------------------------

Thanks for the refactor and tests Yi!
Also thanks to Chris for the review, adding to his review, I have a question.
XattrEncoding is doing both encoding and decoding methods implemented. So, 
whether the name should be XattrEnDecoding ?

or Class can be XattrEnDecoder and inside the Type will be enum ?

> Shift XAttr value encoding code out for reuse.
> ----------------------------------------------
>
>                 Key: HADOOP-10567
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10567
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>    Affects Versions: HDFS XAttrs (HDFS-2006)
>            Reporter: Yi Liu
>            Assignee: Yi Liu
>            Priority: Minor
>             Fix For: HDFS XAttrs (HDFS-2006)
>
>         Attachments: HADOOP-10567.patch
>
>
> XAttr value encoding(encode byte[] to string, hex string or base64 string for 
> better display and input) is common, can be reused.  It can be used by 
> FsShell, in http request as parameter and json response.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to