[
https://issues.apache.org/jira/browse/HADOOP-10590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14001681#comment-14001681
]
Daryn Sharp commented on HADOOP-10590:
--------------------------------------
I think it technically looks ok. However the now un-synchronized refresh
methods are rarely if ever called via an admin command. Whereas
{{protocolToAcl}} is accessed for every client connection. Volatiles are
typically not "free", so have you benchmarked the change?
> ServiceAuthorizationManager is not threadsafe
> ----------------------------------------------
>
> Key: HADOOP-10590
> URL: https://issues.apache.org/jira/browse/HADOOP-10590
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.4.0
> Reporter: Benoy Antony
> Assignee: Benoy Antony
> Attachments: HADOOP-10590.patch
>
>
> The mutators in ServiceAuthorizationManager are synchronized. The accessors
> are not synchronized.
> This results in visibility issues when ServiceAuthorizationManager's state
> is accessed from different threads.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
