[ https://issues.apache.org/jira/browse/HADOOP-10625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14010646#comment-14010646 ]
Hadoop QA commented on HADOOP-10625: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12647021/HADOOP-10625.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The following test timeouts occurred in hadoop-common-project/hadoop-common: org.apache.hadoop.http.TestHttpServer {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/3976//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/3976//console This message is automatically generated. > Configuration: names should be trimmed when putting/getting to properties > ------------------------------------------------------------------------- > > Key: HADOOP-10625 > URL: https://issues.apache.org/jira/browse/HADOOP-10625 > Project: Hadoop Common > Issue Type: Bug > Components: conf > Affects Versions: 2.4.0 > Reporter: Wangda Tan > Assignee: Wangda Tan > Attachments: HADOOP-10625.patch, HADOOP-10625.patch, > HADOOP-10625.patch > > > Currently, Hadoop will not trim name when putting a pair of k/v to property. > But when loading configuration from file, names will be trimmed: > (In Configuration.java) > {code} > if ("name".equals(field.getTagName()) && field.hasChildNodes()) > attr = StringInterner.weakIntern( > ((Text)field.getFirstChild()).getData().trim()); > if ("value".equals(field.getTagName()) && field.hasChildNodes()) > value = StringInterner.weakIntern( > ((Text)field.getFirstChild()).getData()); > {code} > With this behavior, following steps will be problematic: > 1. User incorrectly set " hadoop.key=value" (with a space before hadoop.key) > 2. User try to get "hadoop.key", cannot get "value" > 3. Serialize/deserialize configuration (Like what did in MR) > 4. User try to get "hadoop.key", can get "value", which will make > inconsistency problem. -- This message was sent by Atlassian JIRA (v6.2#6252)