[ https://issues.apache.org/jira/browse/HADOOP-10635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14013366#comment-14013366 ]
Alejandro Abdelnur commented on HADOOP-10635: --------------------------------------------- LGTM, +1. I would do a minor change before committing, I'd move the DEFAULT_SECURE_RANDOM_ALG constant to CommonConfigurationKeysPublic.java. > Add a method to CryptoCodec to generate SRNs for IV > --------------------------------------------------- > > Key: HADOOP-10635 > URL: https://issues.apache.org/jira/browse/HADOOP-10635 > Project: Hadoop Common > Issue Type: Sub-task > Components: security > Affects Versions: fs-encryption (HADOOP-10150 and HDFS-6134) > Reporter: Alejandro Abdelnur > Assignee: Yi Liu > Fix For: 3.0.0 > > Attachments: HADOOP-10635.1.patch, HADOOP-10635.patch > > > SRN generators are provided by crypto libraries. the CryptoCodec gives access > to a crypto library, thus it makes sense to expose the SRN generator on the > CryptoCodec API. -- This message was sent by Atlassian JIRA (v6.2#6252)