[ https://issues.apache.org/jira/browse/HADOOP-10376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14028307#comment-14028307 ]
Arpit Agarwal edited comment on HADOOP-10376 at 6/11/14 7:49 PM: ----------------------------------------------------------------- Hi Chris, - {{GenericRefreshRequestProto.identifier}} is still required (should be optional). Looks unintentional since you added a check for {{hasIdentifier}} in the server side translator. +1 otherwise. Thanks for addressing the feedback. was (Author: arpitagarwal): Hi Chris, - {{GenericRefreshRequestProto.identifier}} is still required. Looks unintentional since you added a check for {{hasIdentifier}} in the server side translator. +1 otherwise. Thanks for addressing the feedback. > Refactor refresh*Protocols into a single generic refreshConfigProtocol > ---------------------------------------------------------------------- > > Key: HADOOP-10376 > URL: https://issues.apache.org/jira/browse/HADOOP-10376 > Project: Hadoop Common > Issue Type: Improvement > Reporter: Chris Li > Assignee: Chris Li > Priority: Minor > Attachments: HADOOP-10376.patch, HADOOP-10376.patch, > HADOOP-10376.patch, HADOOP-10376.patch, RefreshFrameworkProposal.pdf > > > See https://issues.apache.org/jira/browse/HADOOP-10285 > There are starting to be too many refresh*Protocols We can refactor them to > use a single protocol with a variable payload to choose what to do. > Thereafter, we can return an indication of success or failure. -- This message was sent by Atlassian JIRA (v6.2#6252)