[
https://issues.apache.org/jira/browse/HADOOP-10728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039189#comment-14039189
]
Chris Nauroth commented on HADOOP-10728:
----------------------------------------
Hi, [~mikeliddell]. This patch mostly looks good. I have a few minor
requests, mostly just reiterating what Jenkins said above:
# Let's fix the JavaDoc warnings in {{ResponseReceivedMetricUpdater}}.
# The Findbugs warning is somewhat spurious. I recommend that we make
{{BandwidthGaugeUpdater}} a final class to silence the warning. I don't think
there is any need to support subclassing this.
# All of the new files need the Apache license header at the top.
# I was actually able to reproduce both test failures locally, even after
applying the HADOOP-9559 metrics fix. Could you please investigate? I'm not
sure what's wrong with {{testMetricsAcrossFileSystems}}. For
{{testFinalizerThreadShutdown}}, we won't be able to commit a test that fails
intermittently. I recommend experimenting with {{GenericTestUtils#waitFor}},
which will let you poll the thread count periodically up to a maximum wait
time. Let's see if we can get a consistent test run that way.
Thanks, Mike!
> Metrics system for Windows Azure Storage Filesystem
> ---------------------------------------------------
>
> Key: HADOOP-10728
> URL: https://issues.apache.org/jira/browse/HADOOP-10728
> Project: Hadoop Common
> Issue Type: New Feature
> Components: tools
> Reporter: Mike Liddell
> Assignee: Mike Liddell
> Attachments: HADOOP-10728.1.patch
>
>
> Add a metrics2 source for the Windows Azure Filesystem driver that was
> introduced with HADOOP-9629.
> AzureFileSystemInstrumentation is the new MetricsSource.
> AzureNativeFilesystemStore and NativeAzureFilesystem have been modified to
> record statistics and some machinery is added for the accumulation of
> 'rolling average' statistics.
> Primary new code appears in org.apache.hadoop.fs.azure.metrics namespace.
> h2. Credits and history
> Credit for this work goes to the early team: [~minwei], [~davidlao],
> [~lengningliu] and [~stojanovic] as well as multiple people who have taken
> over this work since then (hope I don't forget anyone): [~dexterb], Johannes
> Klein, [~ivanmi], Michael Rys, [~mostafae], [~brian_swan], [~mikelid],
> [~xifang], and [~chuanliu].
--
This message was sent by Atlassian JIRA
(v6.2#6252)
