[ https://issues.apache.org/jira/browse/HADOOP-10733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14039712#comment-14039712 ]
Hadoop QA commented on HADOOP-10733: ------------------------------------ {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12651807/hadoop-10733-v1.txt against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-common-project/hadoop-common. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4134//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4134//console This message is automatically generated. > Potential null dereference in CredentialShell#promptForCredential() > ------------------------------------------------------------------- > > Key: HADOOP-10733 > URL: https://issues.apache.org/jira/browse/HADOOP-10733 > Project: Hadoop Common > Issue Type: Bug > Reporter: Ted Yu > Assignee: Ted Yu > Priority: Minor > Attachments: hadoop-10733-v1.txt > > > {code} > char[] newPassword1 = c.readPassword("Enter password: "); > char[] newPassword2 = c.readPassword("Enter password again: "); > noMatch = !Arrays.equals(newPassword1, newPassword2); > if (noMatch) { > Arrays.fill(newPassword1, ' '); > {code} > newPassword1 might be null, leading to NullPointerException in Arrays.fill() > call. > Similar issue for the following call on line 381: > {code} > Arrays.fill(newPassword2, ' '); > {code} -- This message was sent by Atlassian JIRA (v6.2#6252)