[ https://issues.apache.org/jira/browse/HADOOP-10674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14042955#comment-14042955 ]
Hadoop QA commented on HADOOP-10674: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12652302/c10674_20140624.patch against trunk revision . {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 1.3.9) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs: org.apache.hadoop.ipc.TestIPC {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/4165//testReport/ Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/4165//console This message is automatically generated. > Rewrite the PureJavaCrc32 loop for performance improvement > ---------------------------------------------------------- > > Key: HADOOP-10674 > URL: https://issues.apache.org/jira/browse/HADOOP-10674 > Project: Hadoop Common > Issue Type: Improvement > Components: performance, util > Reporter: Tsz Wo Nicholas Sze > Assignee: Tsz Wo Nicholas Sze > Attachments: c10674_20140609.patch, c10674_20140609b.patch, > c10674_20140610.patch, c10674_20140612.patch, c10674_20140619.patch, > c10674_20140624.patch > > > Below are some performance improvement opportunities performance improvement > in PureJavaCrc32. > - eliminate "off += 8; len -= 8;" > - replace T8_x_start with hard coded constants > - eliminate c0 - c7 local variables > In my machine, there are 30% to 50% improvement for most of the cases. -- This message was sent by Atlassian JIRA (v6.2#6252)