[
https://issues.apache.org/jira/browse/HADOOP-10695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14046482#comment-14046482
]
Alejandro Abdelnur commented on HADOOP-10695:
---------------------------------------------
Some minor nits:
* The config prefix should be "hadoop.security.kms.client."
* The timeout key/default constants should be public.
* Use the key constant from the testcase.
* In the testcase, no need to define the var for the result, simply
{kp.getKeys();}} will do.
+1 after they are taken care.
> KMSClientProvider should respect a configurable timeout.
> --------------------------------------------------------
>
> Key: HADOOP-10695
> URL: https://issues.apache.org/jira/browse/HADOOP-10695
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Reporter: Andrew Wang
> Assignee: Mike Yoder
> Fix For: 3.0.0
>
> Attachments: HADOOP-10695.patch, HADOOP-10695.patch,
> HADOOP-10695.patch
>
>
> It'd be good if KMSClientProvider used a timeout, so it doesn't hang forever
> if the KMServer is down.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
