[ https://issues.apache.org/jira/browse/HADOOP-10732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14058577#comment-14058577 ]
Junping Du commented on HADOOP-10732: ------------------------------------- Nice catch, [~tedyu]! Shall we do similar thing as org.apache.hadoop.crypto.key.JavaKeyStoreProvider that to put the write lock in caller (the method of createCredentialEntry())? That sounds more consistent. > Update without holding write lock in JavaKeyStoreProvider#innerSetCredential() > ------------------------------------------------------------------------------ > > Key: HADOOP-10732 > URL: https://issues.apache.org/jira/browse/HADOOP-10732 > Project: Hadoop Common > Issue Type: Bug > Reporter: Ted Yu > Assignee: Ted Yu > Priority: Minor > Attachments: hadoop-10732-v1.txt > > > In > hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/alias/JavaKeyStoreProvider.java, > innerSetCredential() doesn't wrap update with writeLock.lock() / > writeLock.unlock(). -- This message was sent by Atlassian JIRA (v6.2#6252)