[
https://issues.apache.org/jira/browse/HADOOP-10817?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065513#comment-14065513
]
Andrew Wang commented on HADOOP-10817:
--------------------------------------
Hi Tucu, thanks for working on this, I took a look and had some review comments:
* ProxyUsers#refreshSUGC, we should init the new sip before assigning it to the
volatile variable. This way it's not visible before it's ready.
DefaultImpersonationProvider:
* Good time to add some comments about the regexes, namely example matches
* Would be good to Precondition check that init has been called wherever we use
configPrefix or related
* Some basic checking of configPrefix in init as well, e.g. not empty, not null
* ImpersonationProvider needs class annotations. Just a reminder, if this is a
public interface, adding a new method is incompatible. I do see it in branch-2
already.
> ProxyUsers configuration should support configurable prefixes
> --------------------------------------------------------------
>
> Key: HADOOP-10817
> URL: https://issues.apache.org/jira/browse/HADOOP-10817
> Project: Hadoop Common
> Issue Type: Improvement
> Components: security
> Affects Versions: 3.0.0
> Reporter: Alejandro Abdelnur
> Assignee: Alejandro Abdelnur
> Attachments: HADOOP-10817.patch, HADOOP-10817.patch
>
>
> Currently {{ProxyUsers}} and the {{ImpersonationProvider}} are hardcoded to
> use {{hadoop.proxyuser.}} prefixes for loading proxy user configuration.
> Adding the possibility of using a custom prefix will enable reusing the
> {{ProxyUsers}} class from other components (i.e. HttpFS and KMS).
--
This message was sent by Atlassian JIRA
(v6.2#6252)
