[ 
https://issues.apache.org/jira/browse/HADOOP-10750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066096#comment-14066096
 ] 

Alejandro Abdelnur commented on HADOOP-10750:
---------------------------------------------

A few minor things and we are ready to go:

*CachingKeyProvider.java*:
* Remove {{serialVersionUID}} from {{KeyNotFoundException}} 
* no need for {{getCacheExtension()}}, {{getExtension()}} is generified 
* the 2 {{rollNewVersion()}} methods must invalidate the metadatacache

*KMSConfiguration.java*:
. {{KEY_CACHE_TIMEOUT_DEFAULT}} should be higher, i.e. 10 mins

*KMSWebApp.java*:
. we should have a config property to disable cache, not wrapping the 
keyprovider at all. default value, caching == TRUE

*KMS doc*:
. it should mention caching configs, timeouts and enable/disable


> KMSKeyProviderCache should be in hadoop-common
> ----------------------------------------------
>
>                 Key: HADOOP-10750
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10750
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 3.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Arun Suresh
>         Attachments: HADOOP-10750.1.patch, HADOOP-10750.2.patch
>
>
> KMS has {{KMSCacheKeyProvider}}, this class should be available in 
> hadoop-common for users of  {{KeyProvider}} instances to wrap them and avoid 
> several, potentially expensive, key retrievals.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to